Initial import of bcm5974-0.42. Changelog from the absolute beginning:

bcm5974 (0.42) unstable; urgency=low

  * First button click registered.
  * Hooks pre/post-reset added.

 -- Henrik Rydberg <rydberg@euromail.se>  Tue, 01 Jul 2008 20:59:39 +0200

bcm5974 (0.41) unstable; urgency=low

  * The reset_resume kernel function added.

 -- Henrik Rydberg <rydberg@euromail.se>  Sun, 29 Jun 2008 20:59:39 +0200

bcm5974 (0.4) unstable; urgency=low

  * Both finger pressure and width reported.

 -- Henrik Rydberg <rydberg@euromail.se>  Sun, 29 Jun 2008 18:59:39 +0200

bcm5974 (0.31) unstable; urgency=low

  * Administrative changes for kernel.org.

 -- Henrik Rydberg <rydberg@euromail.se>  Fri, 27 Jun 2008 20:59:39 +0200

bcm5974 (0.3) unstable; urgency=low

  * Explicit device structure, use all packages.

 -- Henrik Rydberg <rydberg@euromail.se>  Fri, 27 Jun 2008 18:59:39 +0200

bcm5974 (0.23) unstable; urgency=low

  * Finger release not reported properly.

 -- Henrik Rydberg <rydberg@euromail.se>  Fri, 27 Jun 2008 17:59:39 +0200

bcm5974 (0.22) unstable; urgency=low

  * ABS coordinates more stable with synaptics.

 -- Henrik Rydberg <rydberg@euromail.se>  Thu, 26 Jun 2008 20:59:39 +0200

bcm5974 (0.21) unstable; urgency=low

  * Fixed the relative coordinate scaling.

 -- Henrik Rydberg <rydberg@euromail.se>  Wed, 25 Jun 2008 20:59:39 +0200

bcm5974 (0.2) unstable; urgency=low

  * Misinterpreted pressure input, noise reduction.

 -- Henrik Rydberg <rydberg@euromail.se>  Wed, 25 Jun 2008 20:59:39 +0200

bcm5974 (0.1) unstable; urgency=low

  * First version.

 -- Henrik Rydberg <rydberg@euromail.se>  Tue, 24 Jun 2008 20:59:39 +0200

1 files changed, 689 insertions, 0 deletions

diff --git a/bcm5974.c b/bcm5974.c
new file mode 100644
index 0000000..68f92c5
--- /dev/null
+++ b/bcm5974.c
@@ -0,0 +1,689 @@
+/*
+ * Apple USB BCM5974 (Macbook Air and Penryn Macbook Pro) multitouch driver
+ *
+ * Copyright (C) 2008      Henrik Rydberg (rydberg@euromail.se)
+ *
+ * The USB initialization and package decoding was made by
+ * Scott Shawcroft as part of the touchd user-space driver project:
+ * Copyright (C) 2008      Scott Shawcroft (scott.shawcroft@gmail.com)
+ *
+ * The BCM5974 driver is based on the appletouch driver:
+ * Copyright (C) 2001-2004 Greg Kroah-Hartman (greg@kroah.com)
+ * Copyright (C) 2005      Johannes Berg (johannes@sipsolutions.net)
+ * Copyright (C) 2005      Stelian Pop (stelian@popies.net)
+ * Copyright (C) 2005      Frank Arnold (frank@scirocco-5v-turbo.de)
+ * Copyright (C) 2005      Peter Osterlund (petero2@telia.com)
+ * Copyright (C) 2005      Michael Hanselmann (linux-kernel@hansmi.ch)
+ * Copyright (C) 2006      Nicolas Boichat (nicolas@boichat.ch)
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ *
+ */
+
+#include <linux/kernel.h>
+#include <linux/errno.h>
+#include <linux/init.h>
+#include <linux/slab.h>
+#include <linux/module.h>
+#include <linux/usb/input.h>
+#include <linux/hid.h>
+
+#define APPLE_VENDOR_ID        0x05AC
+
+/* MacbookAir BCM5974, aka wellspring */
+
+#define ATP_WELLSPRING_ANSI    0x0223
+#define ATP_WELLSPRING_ISO     0x0224
+#define ATP_WELLSPRING_JIS     0x0225
+#define ATP_WELLSPRING2_ANSI   0x0230
+#define ATP_WELLSPRING2_ISO    0x0231
+#define ATP_WELLSPRING2_JIS    0x0232
+
+#define ATP_DEVICE(prod) {                                      \
+    .match_flags = (USB_DEVICE_ID_MATCH_DEVICE |                \
+                    USB_DEVICE_ID_MATCH_INT_CLASS |             \
+                    USB_DEVICE_ID_MATCH_INT_PROTOCOL),          \
+      .idVendor = APPLE_VENDOR_ID,                              \
+      .idProduct = (prod),                                      \
+      .bInterfaceClass = USB_INTERFACE_CLASS_HID,               \
+      .bInterfaceProtocol = USB_INTERFACE_PROTOCOL_MOUSE        \
+      }
+
+/* table of devices that work with this driver */
+static const struct usb_device_id atp_table [] = {
+  /* MacbookAir1.1 */
+  ATP_DEVICE(ATP_WELLSPRING_ANSI),
+  ATP_DEVICE(ATP_WELLSPRING_ISO),
+  ATP_DEVICE(ATP_WELLSPRING_JIS),
+
+  /* MacbookProPenryn */
+  ATP_DEVICE(ATP_WELLSPRING2_ANSI),
+  ATP_DEVICE(ATP_WELLSPRING2_ISO),
+  ATP_DEVICE(ATP_WELLSPRING2_JIS),
+
+  /* Terminating entry */
+  {}
+};
+MODULE_DEVICE_TABLE(usb, atp_table);
+
+struct atp_params_t {
+  int devmin; /* device minimum reading */
+  int devmax; /* device maximum reading */
+  int min; /* logical minimum reading */
+  int max; /* logical maximum reading */
+  int fuzz; /* reading noise value */
+  int flat; /* zero */
+};
+
+struct atp_config_t {
+  int ansi, iso, jis; /* the product id of this device */
+  int bt_ep;          /* the endpoint of the button interface */
+  int bt_datalen;     /* data length of the button interface */
+  int tp_ep;          /* the endpoint of the trackpad interface */
+  int tp_datalen;     /* data length of the trackpad interface */
+  struct atp_params_t x; /* horizontal limits */
+  struct atp_params_t y; /* vertical limits */
+  struct atp_params_t p; /* finger pressure limits */
+  struct atp_params_t w; /* finger width limits */
+};
+
+/* trackpad header structure */
+struct tp_header_t {
+  u8 unknown1[16];   /* constants, timers, etc */
+  u8 nfinger;        /* number of fingers on trackpad */
+  u8 unknown2[9];    /* constants, timers, etc */
+};
+
+/* trackpad finger structure */
+struct tp_finger_t {
+  __le16 origin;       /* left/right origin? */
+  __le16 abs_x;        /* absolute x coodinate */
+  __le16 abs_y;        /* absolute y coodinate */
+  __le16 rel_x;        /* relative x coodinate */
+  __le16 rel_y;        /* relative y coodinate */
+  __le16 size_major;   /* finger size, major axis? */
+  __le16 size_minor;   /* finger size, minor axis? */
+  __le16 orientation;  /* 16384 when point, else 15 bit angle */
+  __le16 force_major;  /* trackpad force, major axis? */
+  __le16 force_minor;  /* trackpad force, minor axis? */
+  __le16 unused[3];    /* zeros */
+  __le16 multi;        /* one finger: varies, more fingers: constant */
+};
+
+/* trackpad data structure */
+struct tp_data_t {
+  struct tp_header_t header;
+  struct tp_finger_t finger[16];
+};
+
+/* device constants */
+static const struct atp_config_t atp_config_table[] = {
+  {
+    ATP_WELLSPRING_ANSI,
+    ATP_WELLSPRING_ISO,
+    ATP_WELLSPRING_JIS,
+    0x84, 4,
+    0x81, sizeof(struct tp_data_t),
+    {-4824, 5342, 0, 1280, 16, 0},
+    {-172, 5820, 0, 800, 16, 0},
+    {0, 256, 0, 256, 16, 0},
+    {0, 2048, 0, 256, 16, 0}
+  },
+  {
+    ATP_WELLSPRING2_ANSI,
+    ATP_WELLSPRING2_ISO,
+    ATP_WELLSPRING2_JIS,
+    0x84, 4,
+    0x81, sizeof(struct tp_data_t),
+    {-4824, 5342, 0, 1280, 16, 0},
+    {-172, 5820, 0, 800, 16, 0},
+    {0, 256, 0, 256, 16, 0},
+    {0, 2048, 0, 256, 16, 0}
+  },
+  {}
+};
+
+static inline
+const struct atp_config_t *atp_product_config(struct usb_device *udev)
+{
+  u16 id = le16_to_cpu(udev->descriptor.idProduct);
+  const struct atp_config_t *config;
+  for (config = atp_config_table; config->ansi; ++config)
+    if (config->ansi == id || config->iso == id || config->jis == id)
+      return config;
+  return atp_config_table;
+}
+
+/* Wellspring initialization constants */
+#define ATP_WELLSPRING_MODE_READ_REQUEST_ID   1
+#define ATP_WELLSPRING_MODE_WRITE_REQUEST_ID  9
+#define ATP_WELLSPRING_MODE_REQUEST_VALUE     0x300
+#define ATP_WELLSPRING_MODE_REQUEST_INDEX     0
+#define ATP_WELLSPRING_MODE_VENDOR_VALUE_1    0x01
+#define ATP_WELLSPRING_MODE_VENDOR_VALUE_2    0x05
+
+#define dprintk(format, a...) \
+  { if (debug) printk(KERN_DEBUG format, ##a); }
+
+MODULE_AUTHOR("Henrik Rydberg");
+MODULE_DESCRIPTION("Apple USB BCM5974 multitouch driver");
+MODULE_LICENSE("GPL");
+
+static int debug = 1;
+module_param(debug, int, 0644);
+MODULE_PARM_DESC(debug, "Activate debugging output");
+
+static int atp_wellspring_init(struct usb_device *udev)
+{
+  const struct atp_config_t *cfg = atp_product_config(udev);
+  char *data = kmalloc(8, GFP_KERNEL);
+  int size;
+
+  /* reset button endpoint */
+  if (usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
+                      USB_REQ_CLEAR_FEATURE, USB_RECIP_ENDPOINT,
+                      0, cfg->bt_ep, NULL, 0, 5000)) {
+    err("Could not reset button endpoint");
+    goto error;
+  }
+
+  /* reset trackpad endpoint */
+  if (usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
+                      USB_REQ_CLEAR_FEATURE, USB_RECIP_ENDPOINT,
+                      0, cfg->tp_ep, NULL, 0, 5000)) {
+    err("Could not reset trackpad endpoint");
+    goto error;
+  }
+
+  /* read configuration */
+  size = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
+                         ATP_WELLSPRING_MODE_READ_REQUEST_ID,
+                         USB_DIR_IN | USB_TYPE_CLASS | USB_RECIP_INTERFACE,
+                         ATP_WELLSPRING_MODE_REQUEST_VALUE,
+                         ATP_WELLSPRING_MODE_REQUEST_INDEX, data, 8, 5000);
+
+  if (size != 8) {
+    err("Could not do mode read request from device (Wellspring Raw mode)");
+    goto error;
+  }
+
+  /* apply the mode switch */
+  data[0] = ATP_WELLSPRING_MODE_VENDOR_VALUE_1;
+  data[1] = ATP_WELLSPRING_MODE_VENDOR_VALUE_2;
+
+  /* write configuration */
+  size = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
+                         ATP_WELLSPRING_MODE_WRITE_REQUEST_ID,
+                         USB_DIR_OUT | USB_TYPE_CLASS | USB_RECIP_INTERFACE,
+                         ATP_WELLSPRING_MODE_REQUEST_VALUE,
+                         ATP_WELLSPRING_MODE_REQUEST_INDEX, data, 8, 5000);
+
+  if (size != 8) {
+    err("Could not do mode write request to device (Wellspring Raw mode)");
+    goto error;
+  }
+
+  printk(KERN_INFO "bcm5974: Wellspring mode initialized.\n");
+
+  kfree(data);
+  return 0;
+
+ error:
+  kfree(data);
+  return -EIO;
+}
+
+/* Structure to hold all of our device specific stuff */
+struct atp {
+  char                  phys[64];
+  struct usb_device    *udev;         /* usb device */
+  struct input_dev     *input;        /* input dev */
+  struct atp_config_t   cfg;          /* device configuration */
+  int                   open;         /* >0: open, else closed */
+  int                   suspended;    /* >0: suspended, else open */
+  struct urb           *bt_urb;       /* button usb request block */
+  signed char          *bt_data;      /* button transferred data */
+  unsigned              bt_state;     /* current button state */
+  struct urb           *tp_urb;       /* trackpad usb request block */
+  signed char          *tp_data;      /* trackpad transferred data */
+  unsigned              tp_valid;     /* are the trackpad sensors valid ? */
+};
+
+static inline int raw2int(__le16 x)
+{
+  return (short)le16_to_cpu(x);
+}
+
+static inline int int2scale(const struct atp_params_t *p, int x)
+{
+  return ((p->max-p->min)*x)/(p->devmax-p->devmin);
+}
+
+/**
+ * all value ranges, both device and logical, are assumed to be [a,b).
+ */
+static inline int int2bound(const struct atp_params_t *p, int x)
+{
+  int s = p->min+int2scale(p, x);
+  return s < p->min?p->min:s >= p->max?p->max-1:s;
+}
+
+/**
+ * check quality of reading.
+ * -1: bad data
+ * 0:  ignore this reading
+ * 1:  good reading
+ */
+static int compute_quality(const unsigned char *data, int size)
+{
+  if (size < 26 || (size-26)%28 != 0)
+    return -1;
+
+  return 1;
+}
+
+/**
+ * convert raw data to synaptics sensor output.
+ * returns the number of fingers on the trackpad,
+ * or a negative number in vase of bad data.
+ */
+static int compute_movement(int *abs_x, int *abs_y,
+                            int *rel_x, int *rel_y,
+                            int *pressure, int *width,
+                            struct atp_config_t *cfg,
+                            const unsigned char *data, int size)
+{
+  const int nfinger = (size-26)/28;
+  const struct tp_data_t *tp = (struct tp_data_t *) data;
+
+  if (nfinger) {
+    *abs_x = int2bound(&cfg->x, raw2int(tp->finger->abs_x) - cfg->x.devmin);
+    *abs_y = int2bound(&cfg->y, cfg->y.devmax - raw2int(tp->finger->abs_y));
+    *rel_x = int2scale(&cfg->x, raw2int(tp->finger->rel_x));
+    *rel_y = int2scale(&cfg->y, -raw2int(tp->finger->rel_y));
+    *pressure = int2bound(&cfg->p, raw2int(tp->finger->force_major));
+    *width = int2bound(&cfg->w, raw2int(tp->finger->size_major));
+  } else {
+    *abs_x = 0;
+    *abs_y = 0;
+    *rel_x = 0;
+    *rel_y = 0;
+    *pressure = 0;
+    *width = 0;
+  }
+
+  /* report zero fingers for zero pressure */
+  return *pressure > 0?nfinger:0;
+}
+
+static void atp_button(struct urb *urb)
+{
+  struct atp *dev = urb->context;
+  int button, retval;
+
+  switch (urb->status) {
+  case 0:
+    break;
+  case -EOVERFLOW:
+  case -ECONNRESET:
+  case -ENOENT:
+  case -ESHUTDOWN:
+    dbg("bcm5974: button urb shutting down: %d", urb->status);
+    return;
+  default:
+    dbg("bcm5974: button urb status: %d", urb->status);
+    goto exit;
+  }
+
+  /* drop incomplete datasets */
+  if (dev->bt_urb->actual_length != 4) {
+    dprintk("bcm5974: incomplete button package (first byte: %d, length: %d)\n",
+            (int)dev->bt_data[0], dev->bt_urb->actual_length);
+    goto exit;
+  }
+
+  button = dev->bt_data[1];
+
+  /* only report button state changes */
+  if (button != dev->bt_state) {
+    input_report_key(dev->input, BTN_LEFT, button);
+    input_sync(dev->input);
+  }
+
+  dev->bt_state = button;
+
+ exit:
+  retval = usb_submit_urb(dev->bt_urb, GFP_ATOMIC);
+  if (retval)
+    err("bcm5974: button urb failed: %d", retval);
+}
+
+static void atp_trackpad(struct urb *urb)
+{
+  struct atp *dev = urb->context;
+  int abs_x, abs_y, rel_x, rel_y, pressure, width;
+  int quality, nfinger, retval;
+
+  switch (urb->status) {
+  case 0:
+    break;
+  case -EOVERFLOW:
+  case -ECONNRESET:
+  case -ENOENT:
+  case -ESHUTDOWN:
+    dbg("bcm5974: trackpad urb shutting down: %d", urb->status);
+    return;
+  default:
+    dbg("bcm5974: trackpad urb status: %d", urb->status);
+    goto exit;
+  }
+
+  /* first sample data ignored */
+  if (!dev->tp_valid) {
+    dev->tp_valid = 1;
+    goto exit;
+  }
+
+  /* determine quality of reading */
+  quality = compute_quality(dev->tp_data, dev->tp_urb->actual_length);
+
+  /* drop incomplete datasets */
+  if (quality < 0) {
+    dprintk("bcm5974: incomplete trackpad package "
+            "(first byte: %d, length: %d)\n",
+            (int)dev->tp_data[0], dev->tp_urb->actual_length);
+    goto exit;
+  }
+
+  /* drop poor quality readings */
+  if (quality == 0)
+    goto exit;
+
+  nfinger = compute_movement(&abs_x, &abs_y,
+                             &rel_x, &rel_y,
+                             &pressure, &width,
+                             &dev->cfg,
+                             dev->tp_data, dev->tp_urb->actual_length);
+
+  if (debug > 1) {
+    printk(KERN_DEBUG "bcm5974: x: %04d y: %04d "
+           "dx: %3d dy: %3d p: %3d w: %3d\n",
+           abs_x, abs_y, rel_x, rel_y, pressure, width);
+  }
+
+  input_report_abs(dev->input, ABS_X, abs_x);
+  input_report_abs(dev->input, ABS_Y, abs_y);
+  input_report_abs(dev->input, ABS_PRESSURE, pressure);
+  input_report_abs(dev->input, ABS_TOOL_WIDTH, width);
+  input_report_key(dev->input, BTN_TOOL_FINGER, nfinger == 1);
+  input_report_key(dev->input, BTN_TOOL_DOUBLETAP, nfinger == 2);
+  input_report_key(dev->input, BTN_TOOL_TRIPLETAP, nfinger > 2);
+  input_sync(dev->input);
+
+ exit:
+  retval = usb_submit_urb(dev->tp_urb, GFP_ATOMIC);
+  if (retval)
+    err("bcm5974: trackpad urb failed: %d", retval);
+}
+
+static int atp_open(struct input_dev *input)
+{
+  struct atp *dev = input_get_drvdata(input);
+
+  if (!dev->open) {
+    if (usb_submit_urb(dev->bt_urb, GFP_ATOMIC))
+      goto error;
+    if (usb_submit_urb(dev->tp_urb, GFP_ATOMIC))
+      goto err_free_bt_urb;
+  }
+
+  dev->open = 1;
+  dev->suspended = 0;
+  dev->tp_valid = 0;
+
+  return 0;
+
+ err_free_bt_urb:
+  usb_free_urb(dev->bt_urb);
+ error:
+  return -EIO;
+}
+
+static void atp_close(struct input_dev *input)
+{
+  struct atp *dev = input_get_drvdata(input);
+
+  if (dev->open && !dev->suspended) {
+    usb_kill_urb(dev->tp_urb);
+    usb_kill_urb(dev->bt_urb);
+  }
+
+  dev->open = 0;
+  dev->suspended = 0;
+}
+
+static int atp_probe(struct usb_interface *iface,
+                     const struct usb_device_id *id)
+{
+  int error = -ENOMEM;
+  struct usb_device *udev = interface_to_usbdev(iface);
+  const struct atp_config_t *cfg;
+  struct atp *dev;
+  struct input_dev *input_dev;
+
+  printk(KERN_INFO "bcm5974: Probing device...\n");
+
+  /* find the product index */
+  cfg = atp_product_config(udev);
+
+  /* allocate memory for our device state and initialize it */
+  dev = kzalloc(sizeof(struct atp), GFP_KERNEL);
+  input_dev = input_allocate_device();
+  if (!dev || !input_dev) {
+    err("Out of memory");
+    goto err_free_devs;
+  }
+
+  dev->udev = udev;
+  dev->input = input_dev;
+  dev->cfg = *cfg;
+
+  /* switch to raw sensor mode */
+  if (atp_wellspring_init(udev))
+    goto err_free_devs;
+
+  dev->bt_urb = usb_alloc_urb(0, GFP_KERNEL);
+  if (!dev->bt_urb)
+    goto err_free_devs;
+
+  dev->tp_urb = usb_alloc_urb(0, GFP_KERNEL);
+  if (!dev->tp_urb)
+    goto err_free_bt_urb;
+
+  dev->bt_data = usb_buffer_alloc(dev->udev,
+                                  dev->cfg.bt_datalen,
+                                  GFP_KERNEL,
+                                  &dev->bt_urb->transfer_dma);
+  if (!dev->bt_data)
+    goto err_free_urb;
+
+  dev->tp_data = usb_buffer_alloc(dev->udev,
+                                  dev->cfg.tp_datalen,
+                                  GFP_KERNEL,
+                                  &dev->tp_urb->transfer_dma);
+  if (!dev->tp_data)
+    goto err_free_bt_buffer;
+
+  usb_fill_int_urb(dev->bt_urb, udev,
+                   usb_rcvintpipe(udev, cfg->bt_ep),
+                   dev->bt_data, dev->cfg.bt_datalen,
+                   atp_button, dev, 1);
+
+  usb_fill_int_urb(dev->tp_urb, udev,
+                   usb_rcvintpipe(udev, cfg->tp_ep),
+                   dev->tp_data, dev->cfg.tp_datalen,
+                   atp_trackpad, dev, 1);
+
+  usb_make_path(udev, dev->phys, sizeof(dev->phys));
+  strlcat(dev->phys, "/input0", sizeof(dev->phys));
+
+  input_dev->name = "bcm5974";
+  input_dev->phys = dev->phys;
+  usb_to_input_id(dev->udev, &input_dev->id);
+  input_dev->dev.parent = &iface->dev;
+
+  input_set_drvdata(input_dev, dev);
+
+  input_dev->open = atp_open;
+  input_dev->close = atp_close;
+
+  set_bit(EV_ABS, input_dev->evbit);
+  input_set_abs_params(input_dev, ABS_X,
+                       cfg->x.min, cfg->x.max, cfg->x.fuzz, cfg->x.flat);
+  input_set_abs_params(input_dev, ABS_Y,
+                       cfg->y.min, cfg->y.max, cfg->y.fuzz, cfg->y.flat);
+  input_set_abs_params(input_dev, ABS_PRESSURE,
+                       cfg->p.min, cfg->p.max, cfg->p.fuzz, cfg->p.flat);
+  input_set_abs_params(input_dev, ABS_TOOL_WIDTH,
+                       cfg->w.min, cfg->w.max, cfg->w.fuzz, cfg->w.flat);
+
+  set_bit(EV_KEY, input_dev->evbit);
+  set_bit(BTN_TOOL_FINGER, input_dev->keybit);
+  set_bit(BTN_TOOL_DOUBLETAP, input_dev->keybit);
+  set_bit(BTN_TOOL_TRIPLETAP, input_dev->keybit);
+  set_bit(BTN_LEFT, input_dev->keybit);
+
+  error = input_register_device(dev->input);
+  if (error)
+    goto err_free_buffer;
+
+  /* save our data pointer in this interface device */
+  usb_set_intfdata(iface, dev);
+
+  return 0;
+
+ err_free_buffer:
+  usb_buffer_free(dev->udev, dev->cfg.tp_datalen,
+                  dev->tp_data, dev->tp_urb->transfer_dma);
+ err_free_bt_buffer:
+  usb_buffer_free(dev->udev, dev->cfg.bt_datalen,
+                  dev->bt_data, dev->bt_urb->transfer_dma);
+ err_free_urb:
+  usb_free_urb(dev->tp_urb);
+ err_free_bt_urb:
+  usb_free_urb(dev->bt_urb);
+ err_free_devs:
+  usb_set_intfdata(iface, NULL);
+  kfree(dev);
+  input_free_device(input_dev);
+  return error;
+}
+
+static void atp_disconnect(struct usb_interface *iface)
+{
+  struct atp *dev = usb_get_intfdata(iface);
+
+  usb_set_intfdata(iface, NULL);
+  if (dev) {
+    input_unregister_device(dev->input);
+    usb_buffer_free(dev->udev, dev->cfg.tp_datalen,
+                    dev->tp_data, dev->tp_urb->transfer_dma);
+    usb_buffer_free(dev->udev, dev->cfg.bt_datalen,
+                    dev->bt_data, dev->bt_urb->transfer_dma);
+    usb_free_urb(dev->tp_urb);
+    usb_free_urb(dev->bt_urb);
+    kfree(dev);
+  }
+  printk(KERN_INFO "bcm5974: disconnected\n");
+}
+
+static int atp_suspend(struct usb_interface *iface, pm_message_t message)
+{
+  struct atp *dev = usb_get_intfdata(iface);
+
+  if (dev->open && !dev->suspended++) {
+    usb_kill_urb(dev->tp_urb);
+    usb_kill_urb(dev->bt_urb);
+  }
+
+  return 0;
+}
+
+static int atp_resume(struct usb_interface *iface)
+{
+  struct atp *dev = usb_get_intfdata(iface);
+
+  if (dev->open && !--dev->suspended) {
+    if (usb_submit_urb(dev->bt_urb, GFP_ATOMIC))
+      goto error;
+    if (usb_submit_urb(dev->tp_urb, GFP_ATOMIC))
+      goto err_free_bt_urb;
+  }
+
+  dev->tp_valid = 0;
+  return 0;
+
+ err_free_bt_urb:
+  usb_free_urb(dev->bt_urb);
+ error:
+  return -EIO;
+}
+
+static int atp_reset_resume(struct usb_interface *iface)
+{
+  struct atp *dev = usb_get_intfdata(iface);
+
+  if (dev->suspended == 1) {
+    if (atp_wellspring_init(dev->udev))
+      printk(KERN_INFO "bcm5974: warning: reset failed\n");
+  }
+
+  return atp_resume(iface);
+}
+
+static int atp_pre_reset(struct usb_interface *iface)
+{
+  return atp_suspend(iface, PMSG_ON);
+}
+
+static int atp_post_reset(struct usb_interface *iface)
+{
+  return atp_reset_resume(iface);
+}
+
+static struct usb_driver atp_driver = {
+  .name         = "bcm5974",
+  .probe        = atp_probe,
+  .disconnect   = atp_disconnect,
+  .suspend      = atp_suspend,
+  .resume       = atp_resume,
+  .reset_resume = atp_reset_resume,
+  .pre_reset    = atp_pre_reset,
+  .post_reset   = atp_post_reset,
+  .id_table     = atp_table,
+};
+
+static int __init atp_init(void)
+{
+  return usb_register(&atp_driver);
+}
+
+static void __exit atp_exit(void)
+{
+  usb_deregister(&atp_driver);
+}
+
+module_init(atp_init);
+module_exit(atp_exit);